Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): fix sys table queries run in local mode #8840

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • System tables could appear in the subquery which is hard to detect in AST, so let's find system tables by using a plan visitor way.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@chenzl25 chenzl25 requested a review from xxchan March 28, 2023 16:08
@github-actions github-actions bot added the type/fix Bug fix label Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #8840 (7149df9) into main (9df0e15) will increase coverage by 0.00%.
The diff coverage is 63.63%.

@@           Coverage Diff           @@
##             main    #8840   +/-   ##
=======================================
  Coverage   70.81%   70.82%           
=======================================
  Files        1171     1172    +1     
  Lines      194474   194464   -10     
=======================================
+ Hits       137719   137725    +6     
+ Misses      56755    56739   -16     
Flag Coverage Δ
rust 70.82% <63.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/binder/query.rs 97.22% <ø> (-0.06%) ⬇️
src/frontend/src/binder/relation/mod.rs 73.79% <ø> (-0.33%) ⬇️
src/frontend/src/binder/set_expr.rs 62.24% <ø> (-0.15%) ⬇️
src/frontend/src/optimizer/mod.rs 92.15% <ø> (ø)
src/frontend/src/optimizer/plan_visitor/mod.rs 94.44% <ø> (ø)
...nd/src/optimizer/plan_visitor/sys_table_visitor.rs 58.82% <58.82%> (ø)
src/frontend/src/handler/query.rs 10.62% <80.00%> (-0.12%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan xxchan added this pull request to the merge queue Mar 28, 2023
Merged via the queue into main with commit 50e5517 Mar 28, 2023
@xxchan xxchan deleted the dylan/fix_sys_table_query_run_in_local_mode branch March 28, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants