Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better error message for CREATE SOURCE without connector #8869

Merged
merged 11 commits into from
Mar 30, 2023
Merged

fix: Better error message for CREATE SOURCE without connector #8869

merged 11 commits into from
Mar 30, 2023

Conversation

gengteng
Copy link
Contributor

@gengteng gengteng commented Mar 29, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #8792

Improve error message when 'connector' or 'WITH' clause is missing from a CREATE SOURCE statement.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Error Message

If the 'connector' field is missing from a CEATE SOURCE statement, the user will get an error message:

Protocol error: missing field 'connector'

If the 'WITH' clause is missing from a CREATE SOURCE statement, he or she will get an error message:

Invalid input syntax: missing WITH clause

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@xxchan
Copy link
Member

xxchan commented Mar 30, 2023

One little hint on GitHub (I've changed that): This syntax can close related issue automatically 😄
image

@xxchan xxchan added this pull request to the merge queue Mar 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2023
@gengteng
Copy link
Contributor Author

One little hint on GitHub (I've changed that): This syntax can close related issue automatically 😄 image

Thank you for the reminder. I'll use this syntax when submitting future PRs. 😄

@xxchan
Copy link
Member

xxchan commented Mar 30, 2023

There are compile error after merging main. Please update branch and fix that 🙏

@xxchan xxchan enabled auto-merge March 30, 2023 13:40
@xxchan xxchan added this pull request to the merge queue Mar 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2023
@xxchan xxchan added this pull request to the merge queue Mar 30, 2023
Merged via the queue into risingwavelabs:main with commit 1f14219 Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parser: better error message for CREATE SOURCE without connector
2 participants