Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner & optimizer): use dedup operator for DISTINCT ON #9016

Merged
merged 16 commits into from
Apr 18, 2023

Conversation

xx01cyx
Copy link
Contributor

@xx01cyx xx01cyx commented Apr 6, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Introduce LogicalDedup and StreamDedup plan node for DISTINCT ON.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 3187 files.

Valid Invalid Ignored Fixed
1479 3 1705 0
Click to see the invalid file list
  • src/frontend/src/optimizer/plan_node/logical_dedup.rs
  • src/frontend/src/optimizer/plan_node/stream_dedup.rs
  • src/stream/src/from_proto/append_only_dedup.rs

xx01cyx and others added 3 commits April 6, 2023 10:15
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@xx01cyx xx01cyx marked this pull request as draft April 11, 2023 12:37
@xx01cyx xx01cyx changed the title feat(frontend): use dedup operator for DISTINCT ON feat(planner&optimizer): use dedup operator for DISTINCT ON Apr 12, 2023
@xx01cyx xx01cyx changed the title feat(planner&optimizer): use dedup operator for DISTINCT ON feat(planner & optimizer): use dedup operator for DISTINCT ON Apr 12, 2023
@xx01cyx xx01cyx marked this pull request as ready for review April 12, 2023 05:52
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 3237 files.

Valid Invalid Ignored Fixed
1496 1 1740 0
Click to see the invalid file list
  • src/frontend/src/optimizer/plan_node/generic/dedup.rs

xx01cyx and others added 2 commits April 12, 2023 13:54
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #9016 (285ed32) into main (d76ff7e) will decrease coverage by 0.01%.
The diff coverage is 61.35%.

@@            Coverage Diff             @@
##             main    #9016      +/-   ##
==========================================
- Coverage   70.84%   70.83%   -0.01%     
==========================================
  Files        1201     1205       +4     
  Lines      200517   200753     +236     
==========================================
+ Hits       142056   142211     +155     
- Misses      58461    58542      +81     
Flag Coverage Δ
rust 70.83% <61.35%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/frontend/src/optimizer/plan_node/generic/mod.rs 0.00% <ø> (ø)
src/frontend/src/optimizer/plan_node/mod.rs 93.05% <ø> (ø)
src/frontend/src/utils/stream_graph_formatter.rs 85.44% <0.00%> (-1.96%) ⬇️
src/meta/src/stream/stream_graph/visit.rs 57.36% <0.00%> (-1.37%) ⬇️
src/stream/src/from_proto/append_only_dedup.rs 0.00% <0.00%> (ø)
src/stream/src/from_proto/mod.rs 0.00% <ø> (ø)
.../frontend/src/optimizer/plan_node/generic/dedup.rs 33.33% <33.33%> (ø)
...c/frontend/src/optimizer/plan_node/stream_dedup.rs 43.54% <43.54%> (ø)
src/stream/src/executor/dedup/append_only_dedup.rs 92.59% <80.00%> (-0.54%) ⬇️
.../frontend/src/optimizer/plan_node/logical_dedup.rs 87.17% <87.17%> (ø)
... and 1 more

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xx01cyx xx01cyx requested a review from st1page April 14, 2023 05:33
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. You can come back to see it next week when you start work.

could you please add the logic in src/frontend/src/utils/stream_graph_formatter.rs in this PR before we finish this #9204?

@xx01cyx xx01cyx added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit 6a37378 Apr 18, 2023
7 of 8 checks passed
@xx01cyx xx01cyx deleted the cyx/distinct-on branch April 18, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants