-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planner & optimizer): use dedup operator for DISTINCT ON
#9016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 3187 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1479 | 3 | 1705 | 0 |
Click to see the invalid file list
- src/frontend/src/optimizer/plan_node/logical_dedup.rs
- src/frontend/src/optimizer/plan_node/stream_dedup.rs
- src/stream/src/from_proto/append_only_dedup.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
DISTINCT ON
DISTINCT ON
DISTINCT ON
DISTINCT ON
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 3237 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1496 | 1 | 1740 | 0 |
Click to see the invalid file list
- src/frontend/src/optimizer/plan_node/generic/dedup.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #9016 +/- ##
==========================================
- Coverage 70.84% 70.83% -0.01%
==========================================
Files 1201 1205 +4
Lines 200517 200753 +236
==========================================
+ Hits 142056 142211 +155
- Misses 58461 58542 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. You can come back to see it next week when you start work.
could you please add the logic in src/frontend/src/utils/stream_graph_formatter.rs in this PR before we finish this #9204?
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Introduce
LogicalDedup
andStreamDedup
plan node forDISTINCT ON
.Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note