Added ILLine submodule #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does seem to be not a feature that is needed for the end-user. |
|
As long as the default is true. Tech support becomes way easier when this exists. Also, the end users of r2api are mod devs. |
|
The rule of r2api is to not impact gameplay directly and at worse what will happen is that spamming stack traces will go from already killing frame to maybe a just a little bit more. Very good addition imo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a submodule named ILLine that always loads (shouldload always gives true).
Based on this mod that makes it so on stack traces it tries to replace the 0 on the end with the IL offset of the instruction (inlining can cause this line number to not be correct).
useful for knowing where your code raises an exception