Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BepinEx Nuget package feed for assembly references #309

Merged
merged 21 commits into from Feb 5, 2022

Conversation

xiaoxiao921
Copy link
Member

Remove most of the dlls from libs/ folder since its now handled through the bepinex nuget feed

@harbingerofme
Copy link
Collaborator

@tristanmcpherson can we run a pipeline on this to test if it works?

@tristanmcpherson
Copy link
Member

Can we still support this?

@xiaoxiao921
Copy link
Member Author

We totally can. The issue currently is that the unity core dlls in this repo are not stripped which allow the construct of the objects. But the dlls in the bepinex nuget feeds are all stripped.
We either get rid of the r2api dotnet tests and move them to a project that we would test through a game launch instead of having them launched in a GitHub action.
Or we change the GitHub action so that it replaces the stubbed dlls with non stubbed ones from the dedicated server installation ( which is free ) and run the tests with those.

I personally prefer the first solution much more as we would be able to test all submodules properly and it's something done in a lot of other modding communities too. From Terraria to Valheim ( basically an ultimate ExampleMod that covers basically all different apis available )

@xiaoxiao921
Copy link
Member Author

New commits :

  • R2API.Test are not called from the github action anymore, instead, a bepinex dll test plugin is made available in the Artifact output and contains xunit tests that are called when launching the game.
  • It'll allow for much powerful tests as we are in the same environement the api is used in normally and the submodules hooks will be tested with the game code which is arguably the biggest point of potential failure

- run: dotnet build .
sed -i -E "s/(PluginVersion\s*=\s*)\"0.0.1\"/\1\"$GitVersion_SemVer\"/" R2API//R2API.Test/R2APITest.cs
- name: Build project
uses: actions/setup-dotnet@v1.7.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a dash before uses here

@tristanmcpherson tristanmcpherson merged commit a6d102c into risk-of-thunder:master Feb 5, 2022
@xiaoxiao921 xiaoxiao921 deleted the lib-cleanup branch February 7, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants