New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BepinEx Nuget package feed for assembly references #309
Use BepinEx Nuget package feed for assembly references #309
Conversation
…y public" warning and put it as suggestion : We are bound to modify / call private members because of this project nature
@tristanmcpherson can we run a pipeline on this to test if it works? |
Can we still support this? |
We totally can. The issue currently is that the unity core dlls in this repo are not stripped which allow the construct of the objects. But the dlls in the bepinex nuget feeds are all stripped. I personally prefer the first solution much more as we would be able to test all submodules properly and it's something done in a lot of other modding communities too. From Terraria to Valheim ( basically an ultimate ExampleMod that covers basically all different apis available ) |
…to lib-cleanup
New commits :
|
- run: dotnet build . | ||
sed -i -E "s/(PluginVersion\s*=\s*)\"0.0.1\"/\1\"$GitVersion_SemVer\"/" R2API//R2API.Test/R2APITest.cs | ||
- name: Build project | ||
uses: actions/setup-dotnet@v1.7.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a dash before uses here
Remove most of the dlls from libs/ folder since its now handled through the bepinex nuget feed