feat: SQL module #148
Merged
feat: SQL module #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also done some refactoring to use |
luisdavim
force-pushed
the
sql
branch
3 times, most recently
from
21a1c24
to
50c88cd
Compare
myzie
reviewed
Jan 3, 2024
modules/sql/db.go
Outdated
| func (db *DB) Exec(ctx context.Context, args ...object.Object) object.Object { | ||
| numArgs := len(args) | ||
| if numArgs < 1 { | ||
| return object.Errorf("type error: sql.query() requires at least one argument") |
There was a problem hiding this comment.
Suggested change
| return object.Errorf("type error: sql.query() requires at least one argument") | |
| return object.Errorf("type error: sql.exec() requires at least one argument") |
myzie
reviewed
Jan 3, 2024
modules/sql/db.go
Outdated
| } | ||
|
|
||
| func (db *DB) Inspect() string { | ||
| return "sql_conn()" |
There was a problem hiding this comment.
To match conventions with types defined in other packages it looks like this should be sql.conn. For example in exec the Command type string is exec.command.
There was a problem hiding this comment.
updated, thanks. I was following the pgx module BTW.
There was a problem hiding this comment.
Roger, sounds like I need to update it to match.
myzie
reviewed
Jan 3, 2024
modules/sql/db.go
Outdated
| "github.com/risor-io/risor/op" | ||
| ) | ||
|
|
||
| const DB_CONN object.Type = "db_conn" |
There was a problem hiding this comment.
sql.conn? See other comment.
myzie
reviewed
Jan 3, 2024
Signed-off-by: Luis Davim <dluis@vmware.com>
|
Thanks, I've updated the PR to address your comments. |
myzie
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #145