Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWREQ #4

Closed
iranzo opened this issue Jun 19, 2017 · 1 comment
Closed

HWREQ #4

iranzo opened this issue Jun 19, 2017 · 1 comment

Comments

@iranzo
Copy link
Member

iranzo commented Jun 19, 2017

Hi,
We need to think in a different way to check HW requirements

Most of the shell script is the same but some values and the url's with the recomendations, so they should define some values, and then use an external script to do the actual checking.

This will reduce the lines of codes to mantain/patch in case of error.

Something like for example

hwreq.sh:

MEMTOTAL=6000000
DISKTOTAL=100000

checkhw.sh $MEMTOTAL $DISKTOTAL

Where checkhw.sh contains the actual code of HWREQ and the parameters passed define the values to compare against

zerodayz pushed a commit that referenced this issue Jun 19, 2017
@zerodayz
Copy link
Member

Check new module selection as in 0d7072d

We are now re-using same code multiple times. Please check plugins/openstack on how this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants