Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cases regarding NickServ identification #76

Closed
michalrud opened this issue Oct 10, 2018 · 1 comment
Closed

Test cases regarding NickServ identification #76

michalrud opened this issue Oct 10, 2018 · 1 comment
Labels
improvement Improves on something that already exists quality assurance CI tests, unit tests, integration tests, any kind of testing wontfix This will not be worked on

Comments

@michalrud
Copy link
Contributor

There are some test cases that would be nice to write for #65 , unfortunately I don't have time to do so in a timely manner :(

  1. Test checking that joining the channel doesn't happen before nickserv answers
  2. Test checking that receiving a message from anyone else than nickserv doesn't trigger joining the channel
  3. Consider parsing NickServ messages to understand if we're really identified

If there are any questions, feel free to contact me :) There are also some tests in IrcConnectionTests.js on which new test can base on.
@jwflory jwflory mentioned this issue Oct 10, 2018
Merged
@jwflory jwflory added improvement Improves on something that already exists help wanted Anyone is welcome to help us with this! labels Oct 14, 2018
@jwflory jwflory mentioned this issue Oct 14, 2018
Closed
@jwflory jwflory added the good first issue Good for newcomers label Nov 24, 2018
@jwflory jwflory added the quality assurance CI tests, unit tests, integration tests, any kind of testing label Dec 2, 2018
@jwflory jwflory added this to Backlog in TeleIRC development Feb 2, 2019
@Tjzabel Tjzabel removed this from Backlog in TeleIRC development Sep 15, 2019
@jwflory jwflory removed good first issue Good for newcomers help wanted Anyone is welcome to help us with this! labels Jan 8, 2020
@jwflory
Copy link
Member

jwflory commented Feb 16, 2020

Since we are starting from scratch for the Go v2.x.x rewrite (#163), this will fit into our existing discussions about writing tests (#236). Closing this issue as wontfix since we are not planning to support the v1.x.x versions once the rewrite is complete.

@jwflory jwflory closed this as completed Feb 16, 2020
@jwflory jwflory added the wontfix This will not be worked on label Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improves on something that already exists quality assurance CI tests, unit tests, integration tests, any kind of testing wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michalrud @jwflory