Option to hide statusbar button #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjoydip-zz
reviewed
May 7, 2018
src/Config.ts
Outdated
| @@ -96,4 +96,8 @@ export class Config { | |||
| public static get getMount(): Array<Array<string>> { | |||
| return Config.getSettings<Array<Array<string>>>('mount'); | |||
| } | |||
|
|
|||
| public static get getShowOnStatusbar(): boolean { | |||
| return Config.getSettings<boolean>('showOnStatusbar') || false; | |||
There was a problem hiding this comment.
false is meaningless here. Because default value set on settings. So it always get true
mxschmitt
requested changes
May 9, 2018
There was a problem hiding this comment.
LGTM, but please fix the eslint errors:
https://travis-ci.org/ritwickdey/vscode-live-server/builds/375844209#L895-L896
|
Sorry for that, it wasn't picking up the spacing issue when i ran the linter locally. Should be right now :) |
|
Thanks a lot for the PR 💟 |
ritwickdey
added a commit
that referenced
this pull request
May 13, 2018
ritwickdey
added a commit
that referenced
this pull request
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I haven't done this correctly because I'm a bit of a newbie to vscode extensions, and to contributing to code in general.
I just thought there should be an option to hide the "Go Live" button in the statusbar, I can't disable the extension because it is dependency for Live Sass Compiler, but it's a button I don't need because in most workspaces I'm not using it directly.
I thought I'd try doing it myself...