Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Browser Preview. Fixes #343 #352

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

auchenberg
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other: <!-- Please describe: -->

What is the current behavior?

This PR adds support for Browser Preview via a new setting, as described in #343

What is the new behavior?

Adds the ability to use Live Server with an in-editor browser.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ritwickdey ritwickdey merged commit 41df0b0 into ritwickdey:master Apr 8, 2019
@ritwickdey
Copy link
Owner

Thank you so much 💘

@auchenberg
Copy link
Contributor Author

🎉

@auchenberg
Copy link
Contributor Author

@ritwickdey When will this get published?

@ritwickdey
Copy link
Owner

Hi @auchenberg, I'm actully worrying about #285 (issue for chokidar library). Last time I fix it by changing old fse binary manually (#285 (comment)).

And I don't know it'll work anymore.. (I don't have macbook). That's why I waiting for a diffrent solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants