-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
responsive css #17
Comments
Can you post a screenshot ? |
For vine there is an option to set its width . So better you write your own css based on the div width in which you are using the plugin and not the device width. |
You can always add your css over the default one according to your needs. If you have some solution that will be consistent in all cases then only it can be implemented in the plugin. |
Thnx. fixed it by getting the class width and parsing it true embed.js
For the pdf and youtube i will create custom css for phones. |
Can you send a PR ? |
What is a PR :P |
Its Pull Request. see this |
Never did it before. Ill read it as soon as ! |
Though your solution will work but i will have to include this responsiveness code inside the plugin as on each resize your code will reload the whole content. This means repeated http requests. Thats never good. I will see what i can do. |
can you also set in your next release the hight of the iframe fore VINE + 2 pixels? 158 seems te be to short for the last borderline from Vine opts.vineOptions.width + 160 |
currently working on a iframe refresh after resize window, i added class="ejs-vine-iframe" on the iframe:
|
If default size is 500 for vine, and opening page with vine on smaller device the vine width is 500px. resizing from large window to smaller works, vine shrinks too. but when resizing from very small to big window the vine does not resize bigger anymore, maybey it's an solution to get the width of the element div and take a amount of pixels to lower the width. when resizing then always resize the vine box too. |
Actually here width that you set is maxWidth but i guess yours solution seems better .I will fix this
|
Now there are slight change in options vineOptions:{
maxWidth:500,
type:'postcard', //'postcard' or 'simple' embedding
responsive:false // whether to make the vine embed responsive
}, I guess you can understand the function about how it works. If not do reply here. I am closing this issue now. |
thank you for this :) |
The display of PDF/Video is not nicely displayed on small devcies phones The PDF/Video becomes a box with sliders .
@media only screen and (min-width: 480px) and (max-width: 767px) { }
@media only screen and (max-width: 479px) { }
The text was updated successfully, but these errors were encountered: