Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videowidth/heigt #3

Closed
ghost opened this issue Mar 20, 2015 · 3 comments
Closed

Videowidth/heigt #3

ghost opened this issue Mar 20, 2015 · 3 comments
Labels
question

Comments

@ghost
Copy link

ghost commented Mar 20, 2015

It would be nice if the video width can be px or % and the height can be auto-calculated.
@ritz078
Copy link
Owner

ritz078 commented Mar 20, 2015

  1. If you want to use % you can use css to do that. but that will just resize the video iframe (as iframes don't support dimensions in percentage.
  2. And the current videoWidth and videoHeight options already are in px.
    Eg: videoWidth : 100 means 100px
  3. Auto calculation is already implemented if you set only height then width will automatically be adjusted in appropriate ratio and vice versa.

@ritz078
Copy link
Owner

ritz078 commented Mar 20, 2015

I will update the readme so that these options become more clear.

@ghost
Copy link
Author

ghost commented Mar 20, 2015

Thanx for reply

ritz078 pushed a commit that referenced this issue Mar 8, 2017
@kanikasaini
Merge pull request #3 from kanikasaini/test
e025751 
Update utils.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ritz078