2 decorate class

[rivasbolinga]

Hi! 👋🏼
I have completed my second milestone in the project school-library and I would like to have your Review before merge it. Here is a little summary:

General requirements

• No linter errors. ✅ ✅ ✅
• Correct use Gitflow. ✅ ✅ ✅
• Documented in a professional way. ✅ ✅ ✅

Ruby requirements

• Follow our list of best practices for Ruby. ✅ ✅ ✅

Project requirements

Interface

• Create a class Nameable. ✅
  • Implement a method called correct_name that will raise a NotImplementedError. ✅

Turn your Person class to Nameable

• Person class inherits from Nameable ✅
• Create a method correct_name implemented. It should simply return the name attribute. ✅

Prepare base Decorator

• Inherits from Nameable. ✅
• In the constructor assign a nameable object from params to an instance variable. ✅
• Implement the correct_name method that returns the result of the correct_name method of the @nameable. ✅

Prepare CapitalizeDecorator and TrimmerDecorator

• For the CapitalizeDecorator: ✅
  • Create a class that inherits from the base Decorator class.
  • Implement a method correct_name that capitalizes the output of @nameable.correct_name.
• For the TrimmerDecorator: ✅
  • Create a class that inherits from the base Decorator class.
  • Implement a method correct_name that makes sure that the output of @nameable.correct_name has a maximum of 10 characters. If it's longer it should trim the word.

---

If you have any question, don't hesitate to contact me by Slack or Zoom. Hope you like it and have a nice day

[iambenkis]

Hi @rivasbolinga ,

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

Decorate class ✔️
Trimmer class ✔️
Capitalize class ✔️
The project is running successfully ✔️
Descriptive pull request ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.