Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add desktop file #505

Merged
merged 1 commit into from Jan 8, 2022
Merged

Conversation

NickHastings
Copy link
Contributor

I recently made a river Debian package and included a desktop file to be installed in /usr/share/wayland-sessions. I noticed that the river-git AUR package does the same thing, So, to avoid duplicating work and to keep things consistent between distributions, I thought it would be worthwhile if upstream river shipped with a desktop file that all packagers could make use of. This desktop file in this branch is almost identical to the one from AUR river-git differing only in the capitalization for "River" and in the addition of a newline at the end of the file.

@novakne
Copy link
Contributor

novakne commented Jan 8, 2022

See #495 for why there are no plans to add it.

Copy link
Member

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think having this in the contrib directory and not officially supported is a good compromise actually. It won't be installed by zig build automatically but distributions wanting to use it can very simply install it manually.

Thanks!

@ifreund ifreund merged commit 0c3a581 into riverwm:master Jan 8, 2022
@NickHastings
Copy link
Contributor Author

Excellent! That's one thing I can cross off the list of things that the "Debian High Command" don't like about the package I'm building!

FYI https://mentors.debian.net/package/river/ and https://lintian.debian.org/tags/maintainer-desktop-entry

@NickHastings NickHastings deleted the desktop-file branch May 8, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants