river: predefine tags for app-id and title #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,6 +175,30 @@ pub fn shouldFloat(self: Self, view: *View) bool { | |||
| return false; | |||
| } | |||
|
|
|||
| pub fn getSpawnTagsFilter(self: Self, view: *View) u32 { | |||
There was a problem hiding this comment.
Suggested change
| pub fn getSpawnTagsFilter(self: Self, view: *View) u32 { | |
| pub fn getSpawnTagsFilter(self: Self, view: *View) ?u32 { |
Return tags if found, null if not.
| @@ -494,6 +494,9 @@ pub fn map(self: *Self) !void { | |||
| if (self.getTitle()) |s| handle.setTitle(s); | |||
| if (self.getAppId()) |s| handle.setAppId(s); | |||
|
|
|||
| self.pending.tags = server.config.getSpawnTagsFilter(self); | |||
There was a problem hiding this comment.
Suggested change
| self.pending.tags = server.config.getSpawnTagsFilter(self); | |
| if (server.config.getSpawnTagsFilter(self)) |tags| self.pending.tags = tags; |
Initial tags are set in .init()
This comment was marked as spam.
This comment was marked as spam.
|
Interested too in this feature! |
|
This patch has grown significant conflicts due to the introduction of the rules system. Now that the rules system has been fleshed out I would be willing to accept a patch adding an action type to set initial tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #201 #472
This PR adds a command to
riverctl. The objective being to pre-define tags for app-id's and titles (similarly to how it is done for floating).Usage example:
riverctl spawn-tags-filter app-id "kitty" 4