Skip to content

Commit

Permalink
fix: allow cockroack to pull with docker creds
Browse files Browse the repository at this point in the history
  • Loading branch information
AngelOnFira committed Jul 4, 2024
1 parent 63b3703 commit 3155ad9
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 9 deletions.
8 changes: 7 additions & 1 deletion infra/tf/k8s_infra/cockroachdb.tf
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,13 @@ resource "helm_release" "cockroachdb" {
]
}
}

image = {
credentials = var.authenticate_all_docker_hub_pulls ? {
registry = "https://index.docker.io/v1/"
username = module.docker_auth.docker_secrets[0].values["docker/registry/docker.io/read/username"]
password = module.docker_auth.docker_secrets[0].values["docker/registry/docker.io/read/password"]
} : null
}
serviceMonitor = {
# TODO: Doesn't work without insecure TLS
enabled = false
Expand Down
3 changes: 2 additions & 1 deletion infra/tf/k8s_infra/init.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ module "docker_auth" {
kubernetes_namespace.rivet_service,
],
var.imagor_enabled ? [kubernetes_namespace.imagor.0] : [],
var.nsfw_api_enabled ? [kubernetes_namespace.nsfw_api.0] : []
var.nsfw_api_enabled ? [kubernetes_namespace.nsfw_api.0] : [],
local.cockroachdb_k8s ? [kubernetes_namespace.cockroachdb.0] : [],
]) :
x.metadata.0.name
]
Expand Down
14 changes: 7 additions & 7 deletions infra/tf/modules/k8s_auth/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,13 @@ resource "kubernetes_secret" "docker_auth" {
".dockerconfigjson" = jsonencode({
auths = {
"https://index.docker.io/v1/" = (
var.authenticate_all_docker_hub_pulls ?
{
auth = base64encode(
"${module.docker_secrets.values["docker/registry/docker.io/read/username"]}:${module.docker_secrets.values["docker/registry/docker.io/read/password"]}"
)
}
: null
var.authenticate_all_docker_hub_pulls ?
{
auth = base64encode(
"${module.docker_secrets[0].values["docker/registry/docker.io/read/username"]}:${module.docker_secrets[0].values["docker/registry/docker.io/read/password"]}"
)
}
: null
)
"ghcr.io" = (
var.deploy_method_cluster ?
Expand Down

0 comments on commit 3155ad9

Please sign in to comment.