fix(workflows): fix loops queries

rivet-gg · Aug 9, 2024 · 6828a5d · 6828a5d
1 parent 8f1099e
commit 6828a5d
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 6 deletions.
diff --git a/lib/chirp-workflow/core/src/db/pg_nats.rs b/lib/chirp-workflow/core/src/db/pg_nats.rs
@@ -951,47 +951,53 @@ impl Database for DatabasePgNats {
 						SET forgotten = TRUE
 						WHERE
 							workflow_id = $1 AND
-							loop_location = $2
+							loop_location = $2 AND
+							forgotten = FALSE
 						RETURNING 1
 					),
 					forget_signal_events AS (
 						UPDATE db_workflow.workflow_signal_events
 						SET forgotten = TRUE
 						WHERE
 							workflow_id = $1 AND
-							loop_location = $2
+							loop_location = $2 AND
+							forgotten = FALSE
 						RETURNING 1
 					),
 					forget_sub_workflow_events AS (
 						UPDATE db_workflow.workflow_sub_workflow_events
 						SET forgotten = TRUE
 						WHERE
 							workflow_id = $1 AND
-							loop_location = $2
+							loop_location = $2 AND
+							forgotten = FALSE
 						RETURNING 1
 					),
 					forget_signal_send_events AS (
 						UPDATE db_workflow.workflow_signal_send_events
 						SET forgotten = TRUE
 						WHERE
 							workflow_id = $1 AND
-							loop_location = $2
+							loop_location = $2 AND
+							forgotten = FALSE
 						RETURNING 1
 					),
 					forget_message_send_events AS (
 						UPDATE db_workflow.workflow_message_send_events
 						SET forgotten = TRUE
 						WHERE
 							workflow_id = $1 AND
-							loop_location = $2
+							loop_location = $2 AND
+							forgotten = FALSE
 						RETURNING 1
 					),	
 					forget_loop_events AS (
 						UPDATE db_workflow.workflow_loop_events
 						SET forgotten = TRUE
 						WHERE
 							workflow_id = $1 AND
-							loop_location = $2
+							loop_location = $2 AND
+							forgotten = FALSE
 						RETURNING 1
 					)
 				SELECT 1

diff --git a/svc/pkg/workflow/db/workflow/migrations/20240809230231_fix_loop_idx.down.sql b/svc/pkg/workflow/db/workflow/migrations/20240809230231_fix_loop_idx.down.sql
diff --git a/svc/pkg/workflow/db/workflow/migrations/20240809230231_fix_loop_idx.up.sql b/svc/pkg/workflow/db/workflow/migrations/20240809230231_fix_loop_idx.up.sql
@@ -0,0 +1,30 @@
+CREATE INDEX idx_workflow_loop_events_loop_location2
+ON workflow_loop_events (workflow_id, loop_location)
+WHERE forgotten = FALSE;
+
+CREATE INDEX idx_workflow_activity_events_loop_location2
+ON workflow_activity_events (workflow_id, loop_location)
+WHERE forgotten = FALSE;
+
+CREATE INDEX idx_workflow_signal_events_loop_location2
+ON workflow_signal_events (workflow_id, loop_location)
+WHERE forgotten = FALSE;
+
+CREATE INDEX idx_workflow_sub_workflow_events_loop_location2
+ON workflow_sub_workflow_events (workflow_id, loop_location)
+WHERE forgotten = FALSE;
+
+CREATE INDEX idx_workflow_signal_send_events_loop_location2
+ON workflow_signal_send_events (workflow_id, loop_location)
+WHERE forgotten = FALSE;
+
+CREATE INDEX idx_workflow_message_send_events_loop_location2
+ON workflow_message_send_events (workflow_id, loop_location)
+WHERE forgotten = FALSE;
+
+DROP INDEX workflow_loop_events@idx_workflow_loop_events_loop_location;
+DROP INDEX workflow_activity_events@idx_workflow_activity_events_loop_location;
+DROP INDEX workflow_signal_events@idx_workflow_signal_events_loop_location;
+DROP INDEX workflow_sub_workflow_events@idx_workflow_sub_workflow_events_loop_location;
+DROP INDEX workflow_signal_send_events@idx_workflow_signal_send_events_loop_location;
+DROP INDEX workflow_message_send_events@idx_workflow_message_send_events_loop_location;