Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update has broken container, missing makemkvcon ? #64

Closed
jcfrosty opened this issue Apr 8, 2021 · 6 comments
Closed

update has broken container, missing makemkvcon ? #64

jcfrosty opened this issue Apr 8, 2021 · 6 comments
Labels
bug creator is no sponsor 😔 No support as per Readme.md

Comments

@jcfrosty
Copy link
Contributor

jcfrosty commented Apr 8, 2021

*** Running /etc/my_init.d/ripper.sh...
Using this daily? Please sponsor me at https://github.com/sponsors/rix1337 - any amount counts!
08.04.2021 13:58:31 : Starting Ripper. Optical Discs will be detected and ripped within 60 seconds.
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 13:58:31 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 13:59:31 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 13:59:31 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 14:00:31 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 14:01:31 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 14:02:31 : Unexpected makemkvcon output:
08.04.2021 14:02:31 : Too many errors, ejecting disk and aborting
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
/config/ripper.sh: line 57: makemkvcon: command not found
*** /etc/my_init.d/ripper.sh failed with status 1

The line its complaining about is
INFO=$"makemkvcon -r --cache=1 info disc:9999 | grep DRV:0"
@rix1337 rix1337 added bug creator is no sponsor 😔 No support as per Readme.md labels Apr 8, 2021
@rix1337
Copy link
Owner

rix1337 commented Apr 8, 2021

Thanks for the Issue, I'll look into this when there is time.

@techie2000
Copy link

Confirmed reproducible :

*** Running /etc/my_init.d/ripper.sh...
Using this daily? Please sponsor me at https://github.com/sponsors/rix1337 - any amount counts!
08.04.2021 14:29:38 : Starting Ripper. Optical Discs will be detected and ripped within 60 seconds.
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 14:29:38 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 14:30:38 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 14:31:38 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 14:32:38 : Unexpected makemkvcon output:
/config/ripper.sh: line 34: makemkvcon: command not found
08.04.2021 14:33:38 : Unexpected makemkvcon output:
08.04.2021 14:33:38 : Too many errors, ejecting disk and aborting
/config/ripper.sh: line 56: makemkvcon: command not found
*** /etc/my_init.d/ripper.sh failed with status 1


*** Killing all processes...

@rix1337
Copy link
Owner

rix1337 commented Apr 8, 2021

Just use rix1337/docker-ripper:1.15.4 in the meantime.

@Johi-x
Copy link

Johi-x commented Apr 8, 2021

i have the same issue and did some digging around; it seems like makemkv isn't installed due to the version check being broken since the changed the website for the forum page from https://www.makemkv.com/forum/viewtopic.php?f=3&t=224 to https://forum.makemkv.com/forum/viewtopic.php?f=3&t=224 .
$ curl --silent 'https://www.makemkv.com/forum/viewtopic.php?f=3&t=224'
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently </title>
</head><body>
<h1>Moved Permanently/</h1>
<p>The document has moved <a href="https://forum.makemkv.com/forum/viewtopic.php?f=3&amp;t=224">here</a>.</p>
</body></html>

$ curl --silent 'https://forum.makemkv.com/forum/viewtopic.php?f=3&t=224' | grep MakeMKV.*.for.Linux.is | head -n 1 | sed -e 's/.*MakeMKV //g' -e 's/ .*//g'
1.16.3
Since 1.16.3 is out now the older makemkv version doesn't work for me anymore. from the ripper.log:
MSG:5021,131332,1,"This application version is too old. Please download the latest version at http://www.makemkv.com/ or enter a registration key to continue using the current version."
so it just creates empty folders with the DVD Title

@rix1337
Copy link
Owner

rix1337 commented Apr 8, 2021

Hm, that seems like an easy fix. I'm more than glad to allow willing collaborators to join this project.

@rix1337 rix1337 closed this as completed in 4a82707 Apr 8, 2021
@rix1337
Copy link
Owner

rix1337 commented Apr 8, 2021 •
edited
Loading

Build will be done in ~15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug creator is no sponsor 😔 No support as per Readme.md
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rix1337 @jcfrosty @techie2000 @Johi-x