Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels and auto-deploy to test.pypi.org by using GitHub actions #8

Merged
merged 30 commits into from
Feb 21, 2020

Conversation

hiroshi-matsuda-rit
Copy link
Collaborator

The build targets are linux-(amd64|i686), win-(x64|x86), and macos_x64 with python 3.[6-8].
The variations of macos x86 are dropped because the GitHub actions does not support this architecture, and also, Apple no longer supports 32 bit apps.

These build processes are triggered by pushing commits to any branches.
Please set TEST_PYPI_USER and TEST_PYPI_PASSWORD on the Secret tab of your repository before accepting this PR.

Thanks,

@hiroshi-matsuda-rit
Copy link
Collaborator Author

@rixwew In addition, please make sure to bump up the version number in setup.py.
We used version=0.8.[1-5] to test auto-deploy functions, but maybe we should bump up the minor version for this kind of changes of installing procedure.

@rixwew
Copy link
Owner

rixwew commented Feb 21, 2020

Thank you @hiroshi-matsuda-rit
I tried pip install -i https://test.pypi.org/simple/ dartsclone==0.8.5 , and the command failed when I have not installed cython.
Is it possible to install cython>=0.28 automatically when installing the dartsclone package?

@hiroshi-matsuda-rit
Copy link
Collaborator Author

hiroshi-matsuda-rit commented Feb 21, 2020

@rixwew Oh, I did not see that error while installing local wheel archives.
I'd like to reproduce and revise the problem.

@rixwew
Copy link
Owner

rixwew commented Feb 21, 2020

Thank you @hiroshi-matsuda-rit
I tried it with Ubuntu 19.04 and Python 3.7.

@hiroshi-matsuda-rit
Copy link
Collaborator Author

@rixwew It seems that test.pypi.org might not serve correct cython packages. Actually, I have no idea how to specify the package dependent URLs.

@hiroshi-matsuda-rit
Copy link
Collaborator Author

This is the log when I installed cython>=0.28 from formal pypi before installing dartsclone of test.pypy.org.

$ python -m venv venv381
$ source venv381/bin/activate
(venv381) $ pip install cython>=0.28
WARNING: You are using pip version 19.2.3, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
(venv381) $ pip install -i https://test.pypi.org/simple/ dartsclone==0.8.5
Looking in indexes: https://test.pypi.org/simple/
Collecting dartsclone==0.8.5
  Using cached https://test-files.pythonhosted.org/packages/d9/69/fdcf0d46eb71ce9d1ea7b55903b3f52886a12dda2201d9f69f7746e63b09/dartsclone-0.8.5-cp38-cp38-manylinux1_x86_64.whl
Requirement already satisfied: Cython in ./venv381/lib/python3.8/site-packages (from dartsclone==0.8.5) (0.29.15)
Installing collected packages: dartsclone
Successfully installed dartsclone-0.8.5

Copy link
Owner

@rixwew rixwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @hiroshi-matsuda-rit
As It seems to work fine at pypi.org, I approved this PR.

@hiroshi-matsuda-rit
Copy link
Collaborator Author

hiroshi-matsuda-rit commented Feb 21, 2020

@rixwew Thank you, too! By the way, how about the version number issue? I suppose to bump it up to '0.9.0' or '1.0.0'.

@rixwew
Copy link
Owner

rixwew commented Feb 21, 2020

After merging this PR, I want to change the github action trigger (like on: push :tag :v*) to avoid unexpected release to pypi.org, then I'll bump up to 0.9.0.
First of all, is it okay to merge this PR now? @hiroshi-matsuda-rit

@hiroshi-matsuda-rit
Copy link
Collaborator Author

@rixwew It sounds nice! Please merge this PR, now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants