Cut v1.3 #122
Merged
Cut v1.3 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
Project already has an editorconfig file. Most IDEs support it. Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
Update outdated pakcages to the latst stable versions. Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
- Function to support setting defaults - city and country - Rewrote weather retrieve function. Handles most functionality in scope. Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
- Cleaned up code to be more readable. Sould only handle display and passing through commands to main handler - Added support for flags and better help text Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
Show flags to display version and help text itself in the help message. Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
- Update test cases to reflect change in API - Add more test cases Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
Signed-off-by: Riyadh Al Nur <riyadhalnur@verticalaxisbd.com>
houndci-bot
reviewed
Feb 2, 2018
|
|
||
| describe('Configure defaults', () => { | ||
| it('should print success message if config set successfully', () => { | ||
| return weather.setLocation({city: 'Dhaka', country: 'Bangladesh'}).should.be.fulfilled.then(res => { |
There was a problem hiding this comment.
Too many nested callbacks (4). Maximum allowed is 3 max-nested-callbacks
| }); | ||
|
|
||
| it('should get the weather for custom location', () => { | ||
| return weather.getWeather({scale: 'C', s: 'C', city: 'Kuala Lumpur', country: 'Malaysia'}).should.be.fulfilled.then(res => { |
There was a problem hiding this comment.
Too many nested callbacks (4). Maximum allowed is 3 max-nested-callbacks
| }); | ||
|
|
||
| it('should get the weather for default location and Fahrenheit scale', () => { | ||
| return weather.getWeather({scale: 'F', s: 'F'}).should.be.fulfilled.then(res => { |
There was a problem hiding this comment.
Too many nested callbacks (4). Maximum allowed is 3 max-nested-callbacks
| }); | ||
|
|
||
| it('should get the weather for default location', () => { | ||
| return weather.getWeather({scale: 'C', s: 'C'}).should.be.fulfilled.then(res => { |
There was a problem hiding this comment.
Too many nested callbacks (4). Maximum allowed is 3 max-nested-callbacks
houndci-bot
reviewed
Feb 2, 2018
|
|
||
| describe('Configure defaults', () => { | ||
| it('should print success message if config set successfully', () => { | ||
| return weather.setLocation({city: 'Dhaka', country: 'Bangladesh'}).should.be.fulfilled.then(res => { |
There was a problem hiding this comment.
Too many nested callbacks (4). Maximum allowed is 3 max-nested-callbacks
| }); | ||
|
|
||
| it('should get the weather for custom location', () => { | ||
| return weather.getWeather({scale: 'C', s: 'C', city: 'Kuala Lumpur', country: 'Malaysia'}).should.be.fulfilled.then(res => { |
There was a problem hiding this comment.
Too many nested callbacks (4). Maximum allowed is 3 max-nested-callbacks
| }); | ||
|
|
||
| it('should get the weather for default location and Fahrenheit scale', () => { | ||
| return weather.getWeather({scale: 'F', s: 'F'}).should.be.fulfilled.then(res => { |
There was a problem hiding this comment.
Too many nested callbacks (4). Maximum allowed is 3 max-nested-callbacks
| }); | ||
|
|
||
| it('should get the weather for default location', () => { | ||
| return weather.getWeather({scale: 'C', s: 'C'}).should.be.fulfilled.then(res => { |
There was a problem hiding this comment.
Too many nested callbacks (4). Maximum allowed is 3 max-nested-callbacks
3 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge into master in preparation for release.