New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extraction with optional query #24

Merged

rezigned merged 2 commits into rize:master from kbond:fix-optional-query

Oct 12, 2022

Contributor

kbond commented Oct 11, 2022

$template->extract('/some/{path}{?ref}', '/some/foo'); // throws Uninitialized string offset: 0

$template->extract('/some/{path}{?ref}', '/some/foo?ref=bar'); // works as expected

kbond added 2 commits

October 11, 2022 18:17


          add failing test

23044b8


          add fix

252081c

Member

rezigned commented Oct 12, 2022

Thanks! @kbond

rezigned merged commit 5ed4ba8 into rize:master

kbond deleted the fix-optional-query branch

October 12, 2022 17:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment