Added load, delete and export features in the Types Widget #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravkghildiyal
force-pushed
the
feature
branch
from
7b471ea
to
71f7295
Compare
|
What about adding syntax highlight in the text input? http://doc.qt.io/qt-5/qtwidgets-richtext-syntaxhighlighter-example.html http://doc.qt.io/qt-5/qtwidgets-widgets-codeeditor-example.html |
ITAYC0HEN
reviewed
Feb 4, 2019
ITAYC0HEN
reviewed
Feb 4, 2019
|
@XVilka |
|
@XVilka good point - I have added the issue here https://github.com/radareorg/cutter/issues/1159, Cutter already have a syntax highlighter 👍 |
ITAYC0HEN
requested changes
Feb 4, 2019
xarkes
previously approved these changes
Feb 4, 2019
a1ext
reviewed
Feb 6, 2019
|
I'll make the changes by weekend since I'll finish my exams till then. Thank you all for the reviews! |
gauravkghildiyal
changed the title
gauravkghildiyal
force-pushed
the
feature
branch
from
71f7295
to
5d8c8ac
Compare
gauravkghildiyal
changed the title
gauravkghildiyal
force-pushed
the
feature
branch
from
5d8c8ac
to
a2fd167
Compare
ITAYC0HEN
requested changes
Feb 10, 2019
a1ext
reviewed
Feb 10, 2019
ITAYC0HEN
requested changes
Feb 10, 2019
ITAYC0HEN
approved these changes
Feb 11, 2019
xarkes
approved these changes
Feb 11, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1071 , closes #1074 , closes #1076 .
Preview: