Graph scrolling forever #1195
Graph scrolling forever #1195
Conversation
|
Can't check until agJ would be fixed |
|
|
||
| // Zoom data | ||
| qreal current_scale = 1.0; | ||
|
|
||
| int unscrolled_render_offset_x = 0; | ||
| int unscrolled_render_offset_y = 0; | ||
| int offset_x = 0; |
There was a problem hiding this comment.
I would add a comment to specify what's the meaning of offset_x and offset_y.
Because I know what your PR does, I know what the offset is for, but otherwise it can be tricky to understand imho.
I believe a \brief would be helpful here.
There was a problem hiding this comment.
commenting comes to the whole graph code after this gets merged, not only here.
| animation_x->setStartValue(horizontalScrollBar()->value()); | ||
| animation_x->setEndValue(target_x); | ||
| animation_x->setEasingCurve(QEasingCurve::InOutQuad); | ||
| animation_x->start(QAbstractAnimation::DeleteWhenStopped); |
There was a problem hiding this comment.
Why did you remove this? Is it handled by centerX followed with blockTransitionedTo?
There was a problem hiding this comment.
because I just thought animation only slows down the users and does not mean anything. this was just copy-pasted from x64dbg code anyway and i don't think we wanna keep this.
There was a problem hiding this comment.
No, the animation was added after x64dbg and does not come from their codebase.
If they have it nowadays it's probably because they took it from us.
| @@ -95,15 +95,14 @@ class GraphView : public QAbstractScrollArea | |||
| ~GraphView() override; | |||
| void paintEvent(QPaintEvent *event) override; | |||
|
|
|||
| // Show a block centered. Animates to it if animated=true | |||
| void showBlock(GraphBlock &block, bool animated = false); | |||
| void showBlock(GraphBlock *block, bool animated = false); | |||
There was a problem hiding this comment.
no, intentionally.
…e11ope/graph_forever3
|
Thank you! Very nice :D |
Graph now scrolls forever and Overview also applies for it.
even when only a node is shown on the screen, you can move the node.
Also refactoring a lot of Graph and Overview code.