DisassemblerGraphView zooming fix #1354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been fixed:
Previously, during zooming using the wheel or +/-, the GraphView was zoomed to the top left corner. As well the scaling was linear, which break an experience, as almost all the modern editors use exponential zooming.
What has been changed:
offset
member ofDisassemblerGraphView
had to be adjusted correspondently. If using +/- the Graph zooms to the center of view;current_scale
now multiples by the exponent, instead of adding the constant.Test plan: