Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis maximum basic block fix #1424

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Analysis maximum basic block fix #1424

merged 1 commit into from
Apr 14, 2019

Conversation

xarkes
Copy link
Member

@xarkes xarkes commented Apr 4, 2019

The option was changed to anal.bb.maxsize, but the format also changed
from integer to 'size' e.g. 512K. This fixes the inputs and uses the
value from r2 (512K).

ITAYC0HEN
ITAYC0HEN requested changes Apr 5, 2019
View reviewed changes
Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the user wont have any indication when they set wrong input. While before it was an integer, it was enough to limit the textbox to integer input. Now the possible input is more complicated with "K" and stuff..

@xarkes
Copy link
Member Author

xarkes commented Apr 5, 2019

I will delete the option.

@ITAYC0HEN
Copy link
Member

Ping @xarkes. It's been a week :)

@xarkes
Copy link
Member Author

xarkes commented Apr 12, 2019

Life goes fast!

@ITAYC0HEN ITAYC0HEN merged commit 5b0ef4c into rizinorg:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ITAYC0HEN ITAYC0HEN ITAYC0HEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xarkes @ITAYC0HEN