Rewrite block sorting and placment so that unreachable blocks are processed. #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessed. * Use DFS instead of Kahn's algorithm for toposort as it makes it easier to deal with loops.
|
Can you show a screenshot of the new behaviour? |
xarkes
requested changes
Apr 6, 2019
|
Example of case blocks without properly analyzed edges being placed the same as everything else instead of being stacked on top of each other.
The input data preparation bug I mentioned in description seems to be on the r2 side as it showed the same case blocks without incoming edges. |
xarkes
approved these changes
Apr 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change block processing order so that unreachable blocks and edges between them are also placed. Prevents unreachable blocks from being stacked in corner (#1419).
Also prevents some instances of same row edges, and upwards going edges that are not part of loop.
From the comments on top of some unreachable blocks it seems that there might be a bug in cutter code preparing input for GraphView, looks like r2 has identified those blocks as part of case switch/case statement.
Test plan (required)
Closing issues
Closes #1419