Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show recent files ordered by opening time. #1462

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Show recent files ordered by opening time. #1462

merged 1 commit into from
Apr 17, 2019

Conversation

karliss
Copy link
Member

@karliss karliss commented Apr 16, 2019

Disable sorting in alphabetical order so that the code ordering by opening time can work.

Test plan (required)

  • Fill recent file list opening few different binaries
  • Before patch open file from near the bottom of list
  • Reopen cutter and observe that last opened file is still at the bottom
  • Apply patch
  • Open file near the bottom of list
  • Reopen cutter and observe that last opened file has been moved to the top

Closing issues

Fixes #1452

ITAYC0HEN
ITAYC0HEN approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

xarkes
xarkes approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@xarkes xarkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@ITAYC0HEN ITAYC0HEN merged commit 1d4bd7e into rizinorg:master Apr 17, 2019
@karliss karliss deleted the recent-file-order branch September 2, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xarkes xarkes xarkes approved these changes

@ITAYC0HEN ITAYC0HEN ITAYC0HEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contradicting recent file behaviour in NewFileDialog
3 participants
@karliss @xarkes @ITAYC0HEN