Basic block highlight #1533
Basic block highlight #1533
Conversation
|
I will try to review when I'll be back home late tonight. |
|
added some optimization to ColorPicker. Now it works way faster than it did before. |
src/Main.cpp
Outdated
| @@ -69,7 +70,7 @@ int main(int argc, char *argv[]) | |||
| } | |||
| ThemeWorker().save(QJsonDocument(updatedTheme), theme); | |||
| } | |||
| settings.setValue("updated_custom_themes", true); | |||
There was a problem hiding this comment.
Since I added new color options like wordHighlight and lineHighlight (which were replaced with r2 options wordhl and linehl in this commit for some reason) we need to update custom theme files
There was a problem hiding this comment.
I've added a version for the color themes to https://github.com/radareorg/cutter/pull/1557
So after this is merged, you just have to raise this version by one instead of adding more settings keys every time.
There was a problem hiding this comment.
Looks good to me, can be merged after adding change for https://github.com/radareorg/cutter/pull/1557
|
Works very good! well done :)
|
|
You should not. Alpha channel is only for line highlight and word highlight options. |
Co-Authored-By: Florian Märkl <info@florianmaerkl.de>
Co-Authored-By: Florian Märkl <info@florianmaerkl.de>
Co-Authored-By: Florian Märkl <info@florianmaerkl.de>
Detailed description
Adds basic block highlight and adds alpha channel for color of word and line highlight.
Graph overview honors the color of basic block as well.
Alpha channel bar appears only when word or line highlight option is selected.
"Unhighlight block" action appears only when user right clicks on highlighted block.