Fix layout save and restore feature (#1515) #1538
Conversation
There was a problem hiding this comment.
I'm not yet convinced of using class names for the object names. I would rather add a static method to DisassemblyWidget, GraphWidget and HexdumpWidget that looks something like this:
static QString getWidgetTypeId() { return "Disassembly"; }Then you can use DisassemblyWidget::getWidgetTypeId() in all the places where the class name is used currently. This way we can also keep the previous states and no migration should be necessary.
|
Briefly. Qt uses object names to save state of mainwindow. Now we use names like "Disassembly", "Graph" etc. If there are few objects with such names, Qt can not distinguish ones. So some sort of ID is obviously needed. I chose to use "ClassName ID" pattern because of more convenient restoring (simply use first word from obj name to find constructor). |
|
Very nice, now it really enhances the whole architecture. Great job and thanks for keeping at it for so long! |
Detailed description
Test plan (required)
Closing issues