Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take in to account selected instruction when moving view offset. #1551

Merged
merged 1 commit into from
May 19, 2019

Conversation

karliss
Copy link
Member

@karliss karliss commented May 17, 2019

Detailed description

This also fixes inability to move up over multi line comment.

There is some room for improvements left in @showRectangle@. Moving to the top of screen isn't always the best thing to do.

Test plan (required)

  • Zoom in long basic block
  • insert some multi line comments
  • move up and down using j/k keys, make sure selected line is always visible

Closing issues

Closes #1542

Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works great

@ITAYC0HEN ITAYC0HEN merged commit c0f4f45 into rizinorg:master May 19, 2019
@karliss karliss deleted the show-instruction branch September 2, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take into account position in bb when focusing on address in graph view
2 participants