Sync hex.pairs eval to "Bytes as pairs" in Hexdump

[ITAYC0HEN]

Detailed description

This PR will make sure the hex.pairs setting is synced with the Hex Pairs action in the Hex Dump widget.

Test plan (required)
Enable "Bytes as pairs" in hex widget
Execute "e hex.pairs" in Console and verify it is true
Disable "Bytes as pairs" in hex widget
Execute "e hex.pairs" in Console and verify it is false

Closing issues

closes #1060

[karliss]

In case of multiple hex widgets state can get de-synchronized. The same happens when changing e.hexpairs in console. Do we want to support that?

[ITAYC0HEN]

Yes they will indeed get de-synchronized since we do have a support ofr multiple hex and r2 doesnt. In this solution, different hex widgets can be with different states for enabling Hex pairs. Unless the metric is recalculated and then they will get into sync again:

[karliss]

More of thoughts about similar settings in future

There are two possible behaviors for settings like this:

• It is consider a global view configuration and gets always synchronized. Mostly synchronizing with some exceptions feel buggy.
• It is considered a view specific setting, there is no synchronization. If saved then saved as part of view layout.

Column count and number base is more of second category. You might want to look at the same data in two different modes in parallel.

Font is the first category.

I feel that hex.pairs is somewhere in the middle, maybe closer to first category. Having support of multiple hex.pairs values in r2 doesn't make sense.

[ITAYC0HEN]

Good points 👍
what do you think would be the best way to handle this pr? Approve it as is? Do you have any concrete improvements you wish to see?

[karliss]

Changes are simple and they improve things. Assuming three is no signal that could be easily connected for detecting config changes good enough for merge.