Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct character width for hexwidget. #1607

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

karliss
Copy link
Member

@karliss karliss commented Jun 17, 2019

Detailed description

  • Use exactly the same font as one used for painting text
  • Character width isn't an integer. For longer 4-8byte words error accumulates and can be visible for some fonts and font sizes.

Test plan (required)

  • Select 8 byte item size and as many columns as possible
  • make sure end of word is aligned with offsets at the top
  • repeat with few different fonts and font sizes
  • Try selecting bytes and text to make sure switching to floating point dindn't break any of the places that require integer division.
    • bytes as pair mode
    • multibyte items

screenshot

align2

Closing issues

Closes #1585

* use correct font
* character width isn't an integer
Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

Copy link
Member

@xarkes xarkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@xarkes xarkes merged commit bb80cbd into rizinorg:master Jun 18, 2019
@karliss karliss deleted the hex-font-size branch July 28, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect item width calculation in hexwidget
3 participants