Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise unsynced widgets. #1609

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Conversation

karliss
Copy link
Member

@karliss karliss commented Jun 18, 2019

Detailed description

Don't raise unsynced widgets when seeking.

Test plan (required)

  • open two graph widgets
  • switch to non memory widget like imports and strings
  • select function to seek and observe that both graph widgets were raised
  • unsync one of them
  • switch to non memory widgets
  • select function to seek and observe that only synced graph was raised

Closing issues

Closes #1455

@ITAYC0HEN
Copy link
Member

The PR is good and does the job. However, I wonder... Wouldn't it be more efficient to disconnect unsynced widget (on context menu click) and connect it back on re-synced (context menu click)?

Syncing and unsyncing is something that rarely happens, while seeking is happening all the time

@karliss
Copy link
Member Author

karliss commented Jun 18, 2019

In theory yes, but I don't think it's currently worth the hassle until we have eliminated all other slowdowns while seeking. Unless we have hundreds of widgets the cost of doing almost nothing will be negligible compared to single widget actually refreshing something.

@ITAYC0HEN
Copy link
Member

Np :)

@thestr4ng3r thestr4ng3r merged commit dba42e7 into rizinorg:master Jun 18, 2019
@karliss karliss deleted the unsync-raise branch September 2, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory Widget Priority ignores unsynced Widgets
3 participants