Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Main Task Synchronization #1723

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Fix Main Task Synchronization #1723

merged 1 commit into from
Aug 30, 2019

Conversation

thestr4ng3r
Copy link
Member

This fixes some delicate race conditions.

From now on, when accessing the RCore in CutterCore, we must always use CORE_LOCK(); and access it like core->... and everything will be fine.

@ITAYC0HEN
Copy link
Member

Approved.
With that, you just stated a very important thing:

From now on, when accessing the RCore in CutterCore, we must always use CORE_LOCK(); and access it like core->... and everything will be fine.

This, in more details, should go to the dev documentation and be told to the dev team

@thestr4ng3r
Copy link
Member Author

It's documented for the core_ member, so one can see it when looking for how to access the RCore. But yeah can be made more clear in general.

@thestr4ng3r thestr4ng3r merged commit 81f7169 into master Aug 30, 2019
@thestr4ng3r thestr4ng3r deleted the task-sync branch August 30, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants