Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more shortcuts to DisassemblyContextMenu #1782

Merged
merged 3 commits into from
Sep 25, 2019

Conversation

ITAYC0HEN
Copy link
Member

Detailed description
This pull request adds three shortcuts for DisassemblyContextMenu

  1. P to define a function
  2. Shift+P to edit a function
  3. U to undefine a function

in addition, this PR will also add an overload method for createFunctionAt to create a function without specifying a name. This will be used in another PR.

On a side note, I really don't like this whole get*Sequence() things. We better have a proper shortcuts structs, globally.

Test plan (required)

  1. Open a binary in Cutter. Got to a function and press U to undefine it
  2. Press P to redefine it
  3. Press Shift+P to edit the newly defined function

Copy link
Member

@xarkes xarkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@xarkes xarkes merged commit 2d34eb2 into rizinorg:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants