Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI for managing layouts #2211

Merged
merged 4 commits into from
May 23, 2020
Merged

Add UI for managing layouts #2211

merged 4 commits into from
May 23, 2020

Conversation

karliss
Copy link
Member

@karliss karliss commented May 22, 2020 •
edited

Your checklist for this pull request

Detailed description

  • Create simple dialog for renaming and deleting layouts
  • Use editable combo-box for saving layout - simplifies editing existing layouts and communicates with the user doing that is possible.

Test plan (required)

layout_manager
Screenshot from 2020-05-23 14-19-59
Screenshot from 2020-05-23 15-42-57

  • Open layout manager when there are no saved layouts
  • save a layout
  • rename layout, make sure layout list in main window gets updated
  • delete layout, make sure layout manager properly clears the list
  • try renaming layout to name used by other layout
  • try renaming layout to reserved name

Closing issues

Closes #694

@ITAYC0HEN ITAYC0HEN marked this pull request as ready for review May 23, 2020 11:38
@ITAYC0HEN ITAYC0HEN marked this pull request as draft May 23, 2020 11:39
@karliss karliss marked this pull request as ready for review May 23, 2020 12:53
ITAYC0HEN
ITAYC0HEN requested changes May 23, 2020
View reviewed changes
Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

docs/source/user-docs/preferences.rst Outdated Show resolved Hide resolved
@ITAYC0HEN
Copy link
Member

Looks good! :)

@karliss @ITAYC0HEN
Update docs/source/user-docs/preferences.rst
ea325cc 
Co-authored-by: Itay Cohen <itaycohen23@gmail.com>
@karliss karliss requested a review from ITAYC0HEN May 23, 2020 20:33
@ITAYC0HEN ITAYC0HEN merged commit 0ea5d6f into rizinorg:master May 23, 2020
@ITAYC0HEN ITAYC0HEN mentioned this pull request May 27, 2020
Merged
@karliss karliss deleted the layout-manager branch June 17, 2020 09:40
karliss referenced this pull request in karliss/cutter-docs Aug 15, 2020
@karliss
Add UI for managing layouts (radareorg/cutter#2211)
ab75ed7 
* Add dialog for deleting and renaming layouts.

* Add documentation.

Co-authored-by: Itay Cohen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ITAYC0HEN ITAYC0HEN ITAYC0HEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout saving/switching
2 participants
@karliss @ITAYC0HEN