Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmdline option to open a file in write mode #2216

Merged
merged 7 commits into from
May 28, 2020

Conversation

tobigrimm
Copy link
Contributor

@tobigrimm tobigrimm commented May 26, 2020

Your checklist for this pull request

Detailed description

Added the cmdline option to open a file directly in write mode. If an analysis level is selected,the file will be opened directly in cutter without displaying any further settings dialog window.

Test plan (required)

  • Check if old functionality still works:
    • Cutter -A 0 TESTFILE Open a file directly without the -w parameter on the commandline. Should open the file directly in cutter and ask to enable write mode if trying to modify.
  • Check if the write mode parameter is handled correctly:
    -- - - Cutter -w -A 0 TESTFILE Open a file directly in cutter in write mode without any further confirmation when modifying it.
    -- - - Cutter -w TESTFILE Open the Load Options to ask for further settings for opening TESTFILE in cutter, with the "Load in write mode (-w)" box already selected:

cutter_writemode_Screenshot_2020-05-26_06-53-51

Closing issues

This closes #2202

Copy link
Member

@xarkes xarkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for your contribution, the PR looks good to me :)

@ITAYC0HEN ITAYC0HEN self-requested a review May 26, 2020 08:03
Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and welcome!

Fantastic job! Looks very nice and works even after rebasing to master (with the latest changes of IO Mode modification).
And you even added the documentation - sweet!

I left a single comment about grammar, other than that, it's good to be merged :)

Thank you!

docs/source/user-docs/command-line.rst Outdated Show resolved Hide resolved
Update to documentation as suggested :)

Co-authored-by: Itay Cohen <itaycohen23@gmail.com>
@tobigrimm
Copy link
Contributor Author

tobigrimm commented May 27, 2020

Changes in the documentation are fine for me, sorry for the delay and thanks for the great feedback :)

@ITAYC0HEN ITAYC0HEN merged commit cd6fc26 into rizinorg:master May 28, 2020
@ITAYC0HEN
Copy link
Member

@tobigrimm Thank you very much! this was a fantastic PR - well described and on-point. We really appreciate taking the time to write the docs and following the guidelines.

So... What's next? :blink: ;)

karliss referenced this pull request in karliss/cutter-docs Aug 15, 2020
* Added an option to directly enable write mode via -w/--writemode to the command line option parser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command line option to open a file in write-mode
4 participants