-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmdline option to open a file in write mode #2216
Conversation
…he commandline option parser
…NewFileOpen Dialog
…eckbox (in case the write mode is set on command line without an analysis level selected) (rizinorg#2202)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your contribution, the PR looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and welcome!
Fantastic job! Looks very nice and works even after rebasing to master (with the latest changes of IO Mode modification).
And you even added the documentation - sweet!
I left a single comment about grammar, other than that, it's good to be merged :)
Thank you!
Update to documentation as suggested :) Co-authored-by: Itay Cohen <itaycohen23@gmail.com>
Changes in the documentation are fine for me, sorry for the delay and thanks for the great feedback :) |
@tobigrimm Thank you very much! this was a fantastic PR - well described and on-point. We really appreciate taking the time to write the docs and following the guidelines. So... What's next? :blink: ;) |
* Added an option to directly enable write mode via -w/--writemode to the command line option parser
Your checklist for this pull request
Detailed description
Added the cmdline option to open a file directly in write mode. If an analysis level is selected,the file will be opened directly in cutter without displaying any further settings dialog window.
Test plan (required)
Cutter -A 0 TESTFILE
Open a file directly without the -w parameter on the commandline. Should open the file directly in cutter and ask to enable write mode if trying to modify.-- - -
Cutter -w -A 0 TESTFILE
Open a file directly in cutter in write mode without any further confirmation when modifying it.-- - -
Cutter -w TESTFILE
Open the Load Options to ask for further settings for opening TESTFILE in cutter, with the "Load in write mode (-w)" box already selected:Closing issues
This closes #2202