Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pci to hexwidget sidepanel #2219

Merged
merged 2 commits into from
May 30, 2020
Merged

add pci to hexwidget sidepanel #2219

merged 2 commits into from
May 30, 2020

Conversation

Surendrajat
Copy link
Member

@Surendrajat Surendrajat commented May 30, 2020 •
edited

Your checklist for this pull request

Detailed description

As requested in #2196 this PR adds support for pci command

Test plan (required)

  • Open Hexdump widget
  • Select bytes
  • From side panel choose Parsing > C bytes with instructions

Closing issues

Closes #2196

karliss
karliss requested changes May 30, 2020
View reviewed changes
Copy link
Member

@karliss karliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if pci mode reused the same architecture and bits settings as disassembly mode in the same widget.

@Surendrajat Surendrajat requested a review from karliss May 30, 2020 08:49
karliss
karliss approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@karliss karliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@karliss karliss merged commit 4ddba1b into rizinorg:master May 30, 2020
ITAYC0HEN
ITAYC0HEN reviewed May 30, 2020
View reviewed changes
Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! <3
I left a small comment that I would like to discuss, something that can be solved with a follow-up PR

src/widgets/HexdumpWidget.cpp Show resolved Hide resolved
@Surendrajat Surendrajat mentioned this pull request May 30, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karliss karliss karliss approved these changes

@ITAYC0HEN ITAYC0HEN ITAYC0HEN left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add pci to hexwidget sidepanel
3 participants
@Surendrajat @karliss @ITAYC0HEN