-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal graph #2234
Horizontal graph #2234
Conversation
#endif | ||
}; | ||
auto layoutMenu = contextMenu->addMenu(tr("Layout")); | ||
horizontalLayoutAction = contextMenu->addAction(tr("Horizontal")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to put it in the Layout->
submenu above/under a separator line. Can also be added with header-items to the view.
With all the truth, it is preferred to give the user as much silence as possible, especially with things that are hardly modified, like the graph layout (most users will just go with whatever they have by default if it works good - and now it is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good :)
I think the docs will need some little changes to reflect the change
https://cutter.re/docs/user-docs/menus/graph-widget-context-menu.html#choose-graph-layout
* Create adapter for converting vertical layout into horizontal * Fix edge spacing override for edges going out of switch statement. * Update documentation.
Your checklist for this pull request
Detailed description
Test plan (required)
Edge spacing fix before:
After:
Closing issues
Closes #2201