Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal graph #2234

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Horizontal graph #2234

merged 3 commits into from
Jun 5, 2020

Conversation

karliss
Copy link
Member

@karliss karliss commented Jun 5, 2020

Your checklist for this pull request

Detailed description

Test plan (required)

context menu
horizontal-layout

Edge spacing fix before:
many_eges_before
After:
many_edges_after

Closing issues
Closes #2201

#endif
};
auto layoutMenu = contextMenu->addMenu(tr("Layout"));
horizontalLayoutAction = contextMenu->addAction(tr("Horizontal"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to put it in the Layout-> submenu above/under a separator line. Can also be added with header-items to the view.

With all the truth, it is preferred to give the user as much silence as possible, especially with things that are hardly modified, like the graph layout (most users will just go with whatever they have by default if it works good - and now it is)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't decide on that. That's probably better. Forgot that the menu contains a lot more when clicking on a block. Moved it.
Screenshot from 2020-06-05 15-05-01

Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good :)

I think the docs will need some little changes to reflect the change

https://cutter.re/docs/user-docs/menus/graph-widget-context-menu.html#choose-graph-layout

@ITAYC0HEN ITAYC0HEN merged commit 837dd63 into rizinorg:master Jun 5, 2020
@karliss karliss deleted the horizontal-graph branch June 17, 2020 09:37
karliss referenced this pull request in karliss/cutter-docs Aug 15, 2020
* Create adapter for converting vertical layout into horizontal

* Fix edge spacing override for edges going out of switch statement.

* Update documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create graph layout horizontal direction adapter
2 participants