-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose asm.reloff.flags in Preferences #2244
Conversation
I am slightly worried about cluttering the first page with too many rarely used settings. @ITAYC0HEN what do you think? |
For this specific case it can use different ui components, for example
Or a combo box maybe (like I did with comments). In general, I was thinking about it as well, and I see couple of ways we can go. Of course, some of them can be combined.
|
@ITAYC0HEN For this change I like the first idea you suggested. It'll save up space and will be consistent with the current logic of |
I think that "Show offsets relative to" can also be grayed out when asm.offset is disabled :) |
46922d7
to
d0cbb3c
Compare
@ITAYC0HEN Cool. It's done now. I've rebased and the build is broken but it should work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now :)
Expose asm.reloff.flags in Preferences (radareorg#2244)
Your checklist for this pull request
Detailed description
This PR adds
asm.reloff.flags
checkbox under Preferences -> Disassembly.Test plan (required)
Go to Preferences -> Disassembly -> check Show offsets relative to a flag (asm.reloff.flags)
Closing issues