-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph optimize #2255
Merged
Merged
Graph optimize #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remaining work
|
thestr4ng3r
approved these changes
Jul 3, 2020
NirmalManoj
pushed a commit
to NirmalManoj/cutter
that referenced
this pull request
Jul 15, 2020
Add optional placement optimization pass which tries to push everything together and ignores the grid.
karliss
referenced
this pull request
in karliss/cutter-docs
Aug 15, 2020
Add optional placement optimization pass which tries to push everything together and ignores the grid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Add optional placement optimization pass which tries to push everything together and ignores the grid after. See details in the code documentation. It gets applied to wide narrow and medium modes.
The gridAAA, gridAAB, gridABA, ... modes were added mostly for preparing the comparison shots and choosing which configurations to expose as narrrow, medium, wide. They are not shown in release mode.
Test plan (required)
Here are some before and after comparison.
Closing issues