Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update r2 and fix renamed configuration variables. #2288

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

karliss
Copy link
Member

@karliss karliss commented Jul 12, 2020

Your checklist for this pull request

Detailed description

Update r2 to 4.5. Don't merge before 4.5 is tagged!

Test plan (required)

  • Open Cutter 1.10.3, change the values for asm.var.subonly and asm.bytespace. ✔️
  • Check that they are saved in cutter.in ✔️
  • Open with the new Cutter ✔️
  • Make sure names in cutter.in have been correctly updated preserving old value ✔️
  • Make sure log doesn't contain warnings about trying to access non-existing r2 config variables ✔️
  • Toggle the settings and restart cutter ✔️
  • Make sure the new values are correctly loaded and shown in the settings dialog ✔️
  • Close cutter and delete Cutter.ini ✔️
  • Start and exit cutter 1.10.3, make sure cutter.ini doesn't contain the renamed variables with either old or new name ✔️
  • Open the new cutter and close ✔️
  • Make sure setting version has been updated but the variables haven't been added to cutter.ini the same way it was before setting upgrade ✔️

Closing issues

Closes #2278

@karliss karliss added this to the 1.11.0 milestone Jul 12, 2020
@karliss karliss marked this pull request as ready for review July 18, 2020 16:53
@karliss karliss force-pushed the r2-update-4.5 branch 5 times, most recently from 8a55b88 to 4fd5d46 Compare July 19, 2020 17:20
@XVilka
Copy link
Member

XVilka commented Jul 20, 2020

The Meson issue looks like mesonbuild/meson#6442

Copy link
Member

@ITAYC0HEN ITAYC0HEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by the test-plan and it looks good :)

@karliss karliss merged commit e14d0d8 into rizinorg:master Jul 20, 2020
@karliss karliss deleted the r2-update-4.5 branch August 5, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asm.var.subonly renamed
4 participants