Add a hotkey for toggling immediate base (#2420)

src/menus/DisassemblyContextMenu.cpp

@@ -404,6 +404,7 @@ void DisassemblyContextMenu::setOffset(RVA offset)
     this->offset = offset;
 
     this->actionSetFunctionVarTypes.setVisible(true);
+    actionToggleBase.setVisible(checkImmediateBaseMenu(getInstObject()));
 }
 
 void DisassemblyContextMenu::setCanCopy(bool enabled)
@@ -416,14 +417,22 @@ void DisassemblyContextMenu::setCurHighlightedWord(const QString &text)
     this->curHighlightedWord = text;
 }
 
-void DisassemblyContextMenu::aboutToShowSlot()
-{
-    // check if set immediate base menu makes sense
-    QJsonObject instObject = Core()->cmdj("aoj @ " + QString::number(
+QJsonObject DisassemblyContextMenu::getInstObject() {
+    return Core()->cmdj("aoj @ " + QString::number(
                                               offset)).array().first().toObject();
+}
+
+// check if set immediate base menu makes sense
+bool DisassemblyContextMenu::checkImmediateBaseMenu(const QJsonObject& instObject) {
     auto keys = instObject.keys();
-    bool immBase = keys.contains("val") || keys.contains("ptr");
-    setBaseMenu->menuAction()->setVisible(immBase);
+    return keys.contains("val") || keys.contains("ptr");
+}
+
+void DisassemblyContextMenu::aboutToShowSlot()
+{
+    QJsonObject instObject = getInstObject();
+
+    setBaseMenu->menuAction()->setVisible(checkImmediateBaseMenu(instObject));
     setBitsMenu->menuAction()->setVisible(true);
 
     // Create structure offset menu if it makes sense

src/menus/DisassemblyContextMenu.h

@@ -233,6 +233,20 @@ private slots:
     };
     QVector<ThingUsedHere> getThingUsedHere(RVA offset);
 
+    /**
+     * @brief Checks if it makes sense to display the immediate base menu
+     * @param instObject Object with instruction data
+     * @returns Return true if the it makes sense to display the set immediate base menu
+     * return false otherwise.
+     */
+    bool checkImmediateBaseMenu(const QJsonObject& instObject);
+
+    /**
+     * @brief Returns json data of the current instruction
+     * @returns Instruction data
+     */
+    QJsonObject getInstObject();
+
     void updateTargetMenuActions(const QVector<ThingUsedHere> &targets);
 };
 #endif // DISASSEMBLYCONTEXTMENU_H