Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unnecessary io.cache=true in tests #1190

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Disable unnecessary io.cache=true in tests #1190

merged 1 commit into from
Jun 4, 2021

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Jun 4, 2021

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

Now that binary loading uses virtual files, some of the io.cache=true calls in our tests are unnecessary. Remove them.

Test plan

CI is green

@wargio
Copy link
Member

wargio commented Jun 4, 2021

some tests has failed.

@XVilka XVilka force-pushed the disable-io-cache branch 3 times, most recently from 37b16e3 to 3e0e30a Compare June 4, 2021 10:37
@XVilka
Copy link
Member Author

XVilka commented Jun 4, 2021

@wargio @thestr4ng3r should be green now.

@wargio
Copy link
Member

wargio commented Jun 4, 2021

@wargio @thestr4ng3r should be green now.

nope.

@XVilka
Copy link
Member Author

XVilka commented Jun 4, 2021

@wargio OpenBSD failure is unrelated:

rz-test(29988) in free(): chunk is already free 0xc8bc8097500
.tasks/test: line 18: 29988 Abort trap              (core dumped) MALLOC_OPTIONS=S rz-test -L -o results.json

@wargio wargio merged commit 2c691b9 into dev Jun 4, 2021
@wargio wargio deleted the disable-io-cache branch June 4, 2021 13:06
@officialcjunior
Copy link
Member

Would be great if someone added a oneliner about what io.cache does on the book's corresponding page, since you guys clearly know what it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants