-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demangling as plugins and libdemangle as external dependency #1656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much better and cleaner this way 👍 🥇
ebfce37
to
2c03342
Compare
@wargio please rebase again to fix the Windows builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most things look good, apart from the following:
Most librz/main
binaries should not have to care about rz_demanglaer_plugin_init/fini IMHO. Maybe only rz-bin needs it.
- TODO: create issue to create new RZ_ARG_TYPE_LANG with autocompletion for
iD
e8bd078
to
78fb057
Compare
requires a version bump once rizinorg/rz-libdemangle#10 is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ed03e4e
to
4aefcdc
Compare
Your checklist for this pull request
Detailed description
Now the demanglers are all handled as external libs (https://github.com/rizinorg/rz-libdemangle).
Also https://github.com/rizinorg/rz-libswift is now a plugin
Closes #1600