Re-design the way ? and ?? are used in rzshell
#1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ret2libc
requested review from
kazarmy,
thestr4ng3r,
wargio and
XVilka
as code owners
ret2libc
force-pushed
the
rzshell-helps-improvements
branch
from
2233e27
to
87ea39e
Compare
ret2libc
force-pushed
the
rzshell-helps-improvements
branch
from
87ea39e
to
3639bfa
Compare
DMaroo
reviewed
Oct 16, 2021
XVilka
approved these changes
Oct 18, 2021
ret2libc
force-pushed
the
rzshell-helps-improvements
branch
from
3639bfa
to
c5558c2
Compare
* `<cmd>?` allows to list the sub-commands of <cmd>. If <cmd> has no sub-commands, the full help of <cmd> is printed instead. * `<cmd>??` allows to always list the full help of <cmd>. Useful when <cmd> is both the name of a group and a command itself. * output modes are only listed as part of the full help and not considered as sub-commands. * fix a bug where `<cmd><mode>?` was just printing the list of sub-commands of <cmd> instead of the full help of <cmd><mode>.
ret2libc
force-pushed
the
rzshell-helps-improvements
branch
from
1ac16f5
to
b3655cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
<cmd>?allows to list the sub-commands of . If has nosub-commands, the full help of is printed instead.
<cmd>??allows to always list the full help of . Useful whenis both the name of a group and a command itself.
considered as sub-commands.
<cmd><mode>?was just printing the list ofsub-commands of instead of the full help of .
Test plan
Use
?, then try?and??on already converted commands. In particular, look for commands that have also a description and some examples, likewB,w6,t,%,eand few others. Please notice how before it was impossible to get the list of sub-modes for commands likezthat is both the name of a sub-tree and of a command.Please test it a bit to check it makes sense.
Closing issues
Closes ##657