Prepare headers for rz-bindgen #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingdeans
force-pushed
the
header-types
branch
2 times, most recently
from
5e04383
to
989ae21
Compare
ret2libc
reviewed
Jul 6, 2022
XVilka
approved these changes
Jul 6, 2022
|
I'm adding type annotations whenever my binding generator needs a container type's contents, so it only covers parts that are being bound. I'm working on adding more bindings here |
|
What do you think if you make this PR "ready" and we start merging the current things? I'd like to avoid huge PRs. |
wingdeans
force-pushed
the
header-types
branch
2 times, most recently
from
659c7d5
to
af5d3db
Compare
ret2libc
reviewed
Jul 19, 2022
XVilka
approved these changes
Jul 20, 2022
wargio
approved these changes
Jul 20, 2022
ret2libc
approved these changes
Jul 21, 2022
|
@wingdeans please resolve the conflict and we will merge this. |
* add some missing /*<types>*/ to rz_core, bin, analysis, cons * add annotation attributes for rz-bindgen * fix extern "C" in some headers * rename RzBuffer functions from length to len * fix rz_core_analysis_name naming conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Detailed description
Container types (eg. RzList) in headers should specify the type of their contents in a block comment.
The format
/*<content_type>*/should work. I've also seen/*<type_key, type_value>*/for hashtables...
Test plan
I am working on scripts to warn about missing annotations.
There isn't a way to verify correctness of annotations (yet).