Improve DWARF5 support and refactor

[imbillow]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
• I've added tests that prove my fix is effective or that my feature works (if possible)
• I've updated the rizin book with the relevant information (if needed)

Detailed description

• Support source lines information extraction for DWARF 5 #3535 (need tests)
• Missing argument in ARMv7 function derived from DWARF #3548
• parse .debug_loclists
• move parse_dwarf_location from dwarf_process.c to dwarf.c
  • dwarf operation (expression) parse
  • dwarf expression evaluation
• .debug_rnglists
• .debug_addr
• add fuzztests

Test plan

Add tests for dwarf5

Closing issues

closes #3548
closes #3535
closes #1004
closes #3541
partially addresses #3581
...

See also https://gcc.gnu.org/wiki/DebugFission

[XVilka]

Please also extract column value when it's available

[XVilka]

Please check also the columns information extraction where available, likely it will be easier to do in the same PR since it's a big refactoring anyway.

[XVilka]

This also could be helpful if you haven't seen it yet: https://gcc.gnu.org/wiki/DebugFission

[XVilka]

One more thing, once you finished the refactoring, I recommend running afl++ fuzzer with DWARF v2-v5 seeds from our testsuite and your own files, to catch obvious bugs at the early stage. Likely most obvious crashes will happen in less than an hour of fuzzing.

https://github.com/AFLplusplus/AFLplusplus/blob/stable/docs/fuzzing_in_depth.md

[XVilka]

@imbillow check also these: https://github.com/gimli-rs/gimli/blob/master/fixtures/self/README.md

[XVilka]

These tests also could be helpful: https://github.com/davea42/libdwarf-regressiontests

[XVilka]

For the record, no need to think about them in this PR, but could be nice to handle them somehow in the future:

• https://www.ibm.com/docs/en/zos/2.4.0?topic=expressions-operators
• https://www.ibm.com/docs/en/zos/2.4.0?topic=entries-base-type
• https://www.ibm.com/docs/en/zos/2.4.0?topic=reference-program-source-cross

For now please just check the doc and think if they can be accomodated in the current architecture at some point in future.

[XVilka]

@imbillow please also rebase on top of the latest dev, especially important since there is upgraded capstone.

[XVilka]

Please update tests output too:

[XX] db/cmd/dwarf Invalid kind for DW_AT_name
RZ_NOPLUGINS=1 /private/var/folders/bc/yvvw2g2s4jlg9r8x7tf61xv800009d/T/woodpecker-local-1287038090/rizinorg/rizin/prefix/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 'aaa
id
' bins/elf/dwarf3_c.elf.patched0
-- stdout
--- expected
+++ actual
@@ -29,7 +29,7 @@
     DW_AT_high_pc                  DW_FORM_addr
     DW_AT_frame_base               DW_FORM_block1
     DW_AT_GNU_all_tail_call_sites  DW_FORM_flag
-    DW_AT_siblings                 DW_FORM_ref4
+    DW_AT_sibling                  DW_FORM_ref4
     5      DW_TAG_variable           [no children] (0x4d)
     DW_AT_name                     DW_FORM_string
     DW_AT_decl_file                DW_FORM_data1
@@ -91,7 +91,7 @@
      DW_AT_high_pc             : 0x1156
      DW_AT_frame_base          : 1 byte block: 0x9c
      DW_AT_GNU_all_tail_call_sites : 1
-     DW_AT_siblings            : <0x7b>
+     DW_AT_sibling             : <0x7b>
 <0x6d>: Abbrev Number: 5    (DW_TAG_variable)
      DW_AT_name                : i
      DW_AT_decl_file           : 1

[XVilka]

You can run bindgen linter locally to check for all errors at once:

Run python3 rz-bindgen/src/lint.py \
Mismatched function annotation for rz_bin_dwarf_expression_dump at <rizin/librz/include/rz_bin_dwarf.h:1[7](https://github.com/rizinorg/rizin/actions/runs/5709818923/job/15469144904?pr=3565#step:6:8)27:1> : RZ_NONNULL (was RZ_NULLABLE at <rizin/librz/bin/dwarf/op.c:1501:1>

[XVilka]

@imbillow could you please open a new PR once you rebase? This was reviewed so much that it's hard to get track of the things?

[XVilka]

@imbillow please update Doxygen for this function in librz/analysis/dwarf_process.c too:

/**
 * \brief Use parsed DWARF function info from Sdb in the function analysis
 *  XXX right now we only save parsed name and variables, we can't use signature now
 *  XXX refactor to be more readable
 * \param analysis
 * \param dwarf_sdb
 */
RZ_API void
rz_analysis_dwarf_integrate_functions(RzAnalysis *analysis, RzFlag *flags) {
	rz_return_if_fail(analysis && analysis->debug_info);
	ht_up_foreach(analysis->debug_info->function_by_addr, dwarf_integrate_function, analysis);
}

There is no SDB anymore

[imbillow]

@imbillow please also rebase on top of the latest dev, especially important since there is upgraded capstone.

I should have rebased the latest dev branch, is there something wrong?

[XVilka]

@imbillow please also rebase on top of the latest dev, especially important since there is upgraded capstone.

I should have rebased the latest dev branch, is there something wrong?

My bad, just cached reference state. After removing dwarf5 local branch and fetching all refs everything is fine.

[imbillow]

@imbillow could you please open a new PR once you rebase? This was reviewed so much that it's hard to get track of the things?

OK