Convert s commands to newshell
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ret2libc
requested review from
kazarmy,
thestr4ng3r,
wargio and
XVilka
as code owners
XVilka
approved these changes
Jan 16, 2021
Maijin
approved these changes
Jan 18, 2021
|
This might really need to be squashed hard. |
|
Damn, my bad. |
ret2libc
force-pushed
the
seek-newshell
branch
from
d458542
to
36bfe90
Compare
* Rename sj/s* and move them under sH. Remove s= * Rename s-* to sH- * Use sd for "seek delta", which moves relative to the current offset * Enforce <cmd> <arg> syntax. So no more "s+16" but "s +16". Command "sHr" is for redo history, "sHu" for undo history. If one wants to move relative to the current address, he needs to do "sd +10"/"sd -10". * Remove `ss` commands in favour of cmd.seek.silent. This was anyway used mainly for scripts, so no need to replicate all `s` commands under `ss. Change a bit rz_core_seek API to avoid dupped entries in seek history
ret2libc
force-pushed
the
seek-newshell
branch
from
d4306a3
to
04fc5bf
Compare
Maijin
approved these changes
Jan 19, 2021
XVilka
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
sj/s*and move them undersH. Removes=sdfor "seek delta", which moves relative to the current offsets+16buts +16. CommandsHris for redo history,sHufor undo history. If one wants to moverelative to the current address, he needs to do
sd +10/sd -10.sscommands in favour of cmd.seek.silent. This was anywayused mainly for scripts, so no need to replicate all
scommandsunder
ss.Test plan
Try all various s commands, visual mode undo/redo.
Closing issues