Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic asm color inconsistencies #4095

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

giridharprasath
Copy link
Contributor

  • Enhanced unknown string parsing in asm generic tokenization

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Added more checks for parsing the generic asm str buf

...

Test plan
Tested on 2 binaries (x86-64, arm64)
Output before:
ScreenShot_2024-01-11_at_05:00:43-AM

Now:
ScreenShot_2024-01-11_at_04:53:58-AM

Before:
ch was getting recognized as a register
ScreenShot_2024-01-11_at_05:01:04-AM

Now:
ScreenShot_2024-01-11_at_05:01:40-AM

...

Closing issues

...

librz/asm/asm.c Show resolved Hide resolved
 - Enhanced unknown string parsing in asm generic tokenization
@XVilka XVilka merged commit 2fcf619 into rizinorg:dev Jan 12, 2024
43 of 44 checks passed
@giridharprasath giridharprasath deleted the giridhar_asm_color branch January 12, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants